--basedir vs. --node-directory

[zooko]

Let's make both admin commands and fs commands use the same.

[zooko]

Also I believe that some tahoe commands accept a final argument to be the basedir, e.g.:

tahoe create-client . tahoe start .

This needs to be documented in the usage strings.

[zooko]

I meant e.g.

tahoe create-client .
tahoe start .

[zooko]

The "some of these accept a final argument" issue has been opened as a separate ticket: #772 (tahoe create-key-generator requires -C).

[davidsarah]

Opinions wanted on:

• whether to unify these to --basedir, --node-directory, or something new like --nodedir
• whether to accept the old options for backward compatibility with existing scripts and/or user habits

[davidsarah]

#715 has a patch for this ticket. Use the patch below instead.

It adds -d/--node-directory to the node admin commands, with the same meaning as --basedir.

[davidsarah]

Basedir/node directory option improvements for ticket798 branch. addresses #188, #706, #715, #772, #890. Version 3 (still disentangled from Unicode changes)

[david-sarah@…]

In [4614/ticket798]:

Basedir/node directory option improvements for ticket798 branch. addresses #188, #706, #715, #772, #890

[davidsarah]

In [4649/ticket798]:

CLI: further improve consistency of basedir options and add tests. addresses #188

(the patch description is wrong, it says 'addresses #118')

[davidsarah]

Fixed on trunk by f952532f0822fbe7 54a9ba8232e2b8e9 a7c474a09893b9aa. NEWS changes were in 0ae556c00ac79d4f 2b15f35b867cebbd.

Leaving open for review.

[zooko]

reviewed (not with 100% care, but...)