Opened at 2009-07-25T18:49:25Z

Closed at 2016-04-28T05:08:28Z

#774 closed defect (invalid)

pycrypto package is required for manhole

Reported by: zooko Owned by: somebody
Priority: minor Milestone: 1.12.0
Component: packaging Version: 1.4.1
Keywords: pycrypto-lib manhole sftp Cc:
Launchpad Bug:

Description

RobK points out that manhole doesn't work if you don't have pycrypto installed. Probably the right thing to do is to express that there is an extra feature of Tahoe-LAFS named "manhole" that requires pycrypto. setuptools has a notion called "extras" for this purpose.

Change History (11)

comment:1 Changed at 2009-07-25T18:50:13Z by zooko

See also #552 (mac buildslave produces builds lacking pycrypto).

comment:2 Changed at 2009-08-07T05:45:40Z by warner

I think you mean #522.

comment:3 Changed at 2009-12-12T04:02:36Z by zooko

See ​http://twistedmatrix.com/trac/ticket/3696 (Add extras_require to top-level setup.py to list Twisted optional dependancies). If the Twisted folks add a declaration that the "manhole" feature of Twisted requires pycrypto, then we can add a declaration that we requre the "manhole" feature of Twisted. That would be better than adding a declaration that we require pycrypto, because really we don't require pycrypto. For example, if Twisted v10 comes out next month and it implements manhole without requiring the pycrypto package, then it would be a shame if Tahoe-LAFS were still declaring that it needed the pycrypto package when, at that point, it wouldn't need it anymore.

comment:4 Changed at 2010-01-16T01:28:10Z by davidsarah

  • Keywords pycrypto manhole added

comment:5 Changed at 2010-02-06T21:59:14Z by davidsarah

  • Keywords sftp added
  • Summary changed from pycrypto package is required for manhole to pycrypto package is required for manhole and SFTP

In order to make SFTP work "out of the box", we gave in and added pycrypto to Tahoe's dependencies, at least for the time being. The situation for SFTP is the same as for manhole (some optional feature of Tahoe depends on something in Twisted that depends on pycrypto), and so Zooko's comment applies to it equally.

comment:6 Changed at 2010-02-15T19:15:28Z by davidsarah

  • Keywords pycrypto-lib added; pycrypto removed

See also #953 (dependency on pycrypto needs to be tested and supported).

comment:7 Changed at 2010-05-30T21:28:18Z by zooko

  • Milestone changed from undecided to 1.7.0

comment:8 Changed at 2010-06-17T04:35:12Z by zooko

  • Milestone changed from 1.7.0 to eventually
  • Summary changed from pycrypto package is required for manhole and SFTP to pycrypto package is required for manhole

#953 is needed for SFTP support in Tahoe-LAFS v1.7. However, this ticket which is about manhole, is not.

Last edited at 2014-09-07T17:27:08Z by daira (previous) (diff)

comment:9 Changed at 2015-11-02T00:21:33Z by warner

The Twisted folks are currently working on removing their dependency on pycrypto, using the cryptography package instead (​discussion, ​twisted#7413). We'll need to remove pycrypto from our dependencies when the Twisted version we use makes the transition.

comment:10 Changed at 2016-03-25T20:23:33Z by daira

Twisted 16.0.0 removed their dependency on PyCrypto.

comment:11 Changed at 2016-04-28T05:08:28Z by warner

  • Milestone changed from eventually to 1.12.0
  • Resolution set to invalid
  • Status changed from new to closed

We removed manhole altogether (in #2367), so this is now INVALID.

Note: See TracTickets for help on using tickets.