#631 new defect

trailing spaces in filenames break the WUI rename function

Reported by: zooko Owned by:
Priority: major Milestone: soon
Component: code-frontend-web Version: 1.3.0
Keywords: wui usability names Cc:
Launchpad Bug:

Description

I accidentally created a child directory named "darcs executables for ". Then I tried to use the "rename" button to change the name to "darcs executables for Windows". I got this HTML:

<html>
  <head>
    <title>Directory SI=iy5il</title>
    <!-- <link href="http://www.allmydata.com/common/css/styles.css"
          rel="stylesheet" type="text/css"/> -->
    <link href="/webform_css" type="text/css" rel="stylesheet" />
    <link href="/tahoe_css" type="text/css" rel="stylesheet" />
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type" />
  </head>

<body>

<h2>Rename in directory SI=iy5il:</h2>

<div class="freeform-form">
    <form action="." method="post" enctype="multipart/form-data">
        <fieldset>
            <legend class="freeform-form-label">Rename child</legend>
            <input type="hidden" name="t" value="rename" />
            <input type="hidden" name="when_done" value="." />

            Rename child:
            <input readonly="true" type="text" name="from_name" value="darcs executables for " />
            to
            <input type="text" name="to_name" />
            <input type="submit" value="rename" />
        </fieldset>
    </form>
</div>

</body></html>

Entering a new name and clicking "rename" yields the text/plain message:

No such child: darcs executables for

I assume that the trailing newline is being stripped somewhere and causing this problem.

Change History (3)

comment:1 Changed at 2010-03-25T02:15:45Z by davidsarah

  • Keywords wui usability added
  • Milestone changed from undecided to 1.7.0

comment:2 Changed at 2010-06-18T23:48:08Z by zooko

  • Milestone changed from 1.7.0 to soon

comment:3 Changed at 2010-06-21T02:57:44Z by davidsarah

  • Keywords names added
Note: See TracTickets for help on using tickets.